fix(animations): avoid animation insertions during router back/refresh #21977
Conversation
| // there may exist a race condition here (within the router functionality) | ||
| // that may end up having DOM nodes be inserted prematurely even though | ||
| // the new DOM is not ready just yet. This is a router-level issue, | ||
| // however animations should be defensive about this situation (issue #21947) |
There was a problem hiding this comment.
how about:
This if statement is a workaround for router issue #21947.
The router sometimes hits a race condition where while a route is being instantiated a new navigation arrives, triggering leave animation of DOM that has not been fully initialized, until this is resolved, we need to handle the scenario when DOM is not in a consistent state during the animation.
Please check if what I wrote is technically correct and makes sense to you. I found your version to be hard to understand.
IgorMinar
added
the
action: cleanup
|
You can preview a1e594c at https://pr21977-a1e594c.ngbuilds.io/. |
matsko
force-pushed
the
animation_insert_race_condition
branch
from
a1e594c
to
5f80904
Compare
|
You can preview 5f80904 at https://pr21977-5f80904.ngbuilds.io/. |
matsko
added
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Closes #19712